• 0 posts
  • 11 comments
Joined 3 years ago
Cake day: July 1st, 2023
  • There are several projects on GitHub I use that are sometimes hard to find answers for questions. They have closed the Discussions on their GitHub page, and if you ask a question by opening an issue they close it and say “go join our discord server”.

    It’s frustrating. You can’t search online for any issues. When you join the discord server, you can search and find lots of questions, but there are very few answers.

  • I made a branch, make commits, and then make a PR. I don’t care about the number of commits because sometimes a reviewer might be able to make more sense of a PR if they view each commit instead of all the changes at once.

    For us we just make sure that the branch builds and passes tests before merging it in, and just do a general look over to make sure everything looks correct, follows best practices, etc. if the UI was changed I usually add screenshots of before/after or a screen recording of me using the feature. Sometimes these can really help a reviewer understand what all the changes mean.