• 0 posts
  • 18 comments
Joined 3 years ago
Cake day: July 2nd, 2023
  • I’m not impressed with how they’re approaching the development. They’ve been rushing cosmic development without taking time to do some things properly. They forked iced and have a huge amount of changes. Instead of keeping the history clean they squashed their changes into a 50,000 line commit. Their compositor has no automated testing last I looked at it. Hundreds of warnings during compilation.

  • I have to work with Gerrit, which requires amending existing commits after they’ve been pushed to the remote branch to address comments. I’ll frequently have lots of commits I’m working on above the commit in review. Along with a couple other branches. Every commit also has to compile and pass tests. I’ll frequently go git rebase -i --autosquash paired with git fixup. I’ve made mistakes before that are hard to untangle. With jj it’s just jj edit <change-id>.

    Or if I want to insert a commit between two others it’s just jj new -A <change-id> to create a new commit after the change id (but BEFORE the previous change that was after the commit). With git I’d need to commit then rebase, put it in the right slot and recompile, rerun tests, re-edit. If I work on a branch I’d need to rebase, possible merge conflicts. jj just puts me on that commit then helps me manage merge conflicts going up. It’s fewer commands focused on what I want to do and less on the tree like git.

  • Telling people they have Stockholm syndrome is not a good way to convince them to change their behavior. Present the pros, be honest about the cons and let people make their own decisions. The jj workflow isn’t for everyone, and sometimes people’s git workflows are simple enough that there isn’t a benefit to learning a new tool. I like jj because I have to deal with complicated workflows for work and jj makes them much easier. At a different job it was much simpler and I wouldn’t have paid too much attention to jj.

  • Jj’s closest equivalent of branches are bookmarks, but they don’t auto update when you pull from a remote. I wish it was more like a git branch in that sense.

    However, editing past commits and reorganizing the tree is MUCH easier in jj. It feels like the commands are more in line with what I want to do rather than having to figure out the specific set of git commands to do what I want.

    I did find the “adding EVERYTHING” behavior to be annoying initially. My workaround was to create a local folder and add it to git ignore and push all those temp files there.

    YMMV but I’ve found it much easier to manage complex workflows with jj compared to git.

  • Not a lawyer, but worked closely with them in the past. It REALLY depends on your employment contract. Changing variable names and language still makes it a derivative work, so it would depend on the original license. I’m assuming it doesn’t have a license which would mean either you or the company owns the copyright: depends on your employment contract. Whether you’re a contractor or full time also affects ownership.

    Without ownership or a license, you do not have the legal right to copy the work or make a derivative of it.

    I’m not clear on whether you actually wrote any code though. If that’s the case (that no code was written) then I’m not really sure how that works out. If you do post it and they find out, AND they’re mad about it, you could definitely get fired. I’m not sure if there could also be legal trouble or not.

    If you need it for a resume item, you can just list it on your resume and talk about it. You could also implement it on your own time (but not share it until you’re sure you’re safe from legal action), that way you could talk about tradeoffs you’ve made, etc. in the real implementation.

    In general, if you’re not sure and you’re worried about getting sued, you should ask a lawyer.